Add instance registry with health polling and fleet dashboard#67
Merged
victor-cuevas merged 6 commits intofeat/admin-portalfrom Mar 17, 2026
Merged
Add instance registry with health polling and fleet dashboard#67victor-cuevas merged 6 commits intofeat/admin-portalfrom
victor-cuevas merged 6 commits intofeat/admin-portalfrom
Conversation
victor-cuevas
force-pushed
the
feat/admin-portal
branch
from
95d343c to
b6fd2e0
Compare
Instance CRUD API (POST/GET/PUT/DELETE /api/instances) with SQLite store, background health poller with three-state machine (unknown → healthy → unreachable after 3 failures, instant recovery), test-connection endpoint, and Vue frontend with Pinia store, AddInstanceModal, InstanceCard/Table with density toggle, and staleness detection.
Replace minimal empty state with a guided welcome screen (portal description + 3-step onboarding flow). Replace window.confirm() with a ConfirmDialog component for instance removal. Add ghost button variant for the Remove action.
Validate addresses as strict host:port (rejects :9090, host:abc, host:0). Cap JSON request bodies at 1 MB. Fix poller failures map leak for deleted instances. Make Probe() accept *http.Client to avoid per-call allocation. Extract shared formatTime, isInstanceStale, STALE_THRESHOLD_MS to utils/instance.js with tests. Fix stale-status inconsistency between table and card views.
Extract component logic into pure functions (validation, formatting, filtering), composables (useInstanceForm, usePolling, useConfirmDialog), and a thin API client so all meaningful frontend logic is testable without vue-test-utils. 65 tests across 7 files.
Fix 12 lint issues (funlen, rangeValCopy, httpNoBody, gosec, govet shadow, revive var-naming, unparam) across Go sources. Add gosec G706 exclusion for admin module matching core. Switch Prettier to single quotes and reformat UI sources.
victor-cuevas
force-pushed
the
feat/admin-instance-registry
branch
from
b71ca16 to
90d1f5f
Compare
victor-cuevas
force-pushed
the
feat/admin-instance-registry
branch
from
90d1f5f to
e72fea1
Compare
arnaugiralt
approved these changes
Mar 12, 2026
Member
arnaugiralt
left a comment
arnaugiralt
left a comment
There was a problem hiding this comment.
LGTM, auth is the missing piece, but it's already tracked and will be implemented in the next few weeks
qarlosh
approved these changes
Mar 13, 2026
Collaborator
|
I found these issues using Copilot, however I think that they are not blocking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan